fix: Matrix encoding roundtrip losing precision. Use f64 instead of f32s.
#48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aborgna-q
force-pushed
the
ab/fix-diagonal-box
branch
from
41b80bc to
c97d380
Compare
johnchildren
approved these changes
Jul 5, 2024
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 5, 2024
## 🤖 New release * `tket-json-rs`: 0.4.1 -> 0.4.2 <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## 0.4.2 (2024-07-05) ### Bug Fixes - Add missing `CnRx` `CnRz` ops ([#49](#49)) - Matrix encoding roundtrip losing precision. Use `f64` instead of `f32`s. ([#48](#48)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). Co-authored-by: hugrbot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #45. The elements in the encoded matrix where deserialized into
f32, which caused a precision loss.