Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup #445

Merged
merged 5 commits into from
Nov 13, 2023
Merged

Cleanup #445

merged 5 commits into from
Nov 13, 2023

Conversation

JulienDoerner
Copy link
Member

With this PR the deprecated libraries EleCa and Dint are removed. This also removes the modules PhotonPropagation, EMCascade and PhotonEleca.

In the test testSimulationExtension.py the EMCascade is replaced by the EMPairProduction and EMInverseComptonScattering

@lukasmerten
Copy link
Member

Please add the removal to the CHANGELOG.

@JulienDoerner
Copy link
Member Author

JulienDoerner commented Oct 27, 2023 •
edited
Loading

I added a new heading for removed features into the CHANGELOG

lukasmerten
lukasmerten approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@lukasmerten lukasmerten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. If nobody complains, I will merge this PR on Friday.

@lukasmerten lukasmerten merged commit 24a8337 into CRPropa:master Nov 13, 2023
1 of 3 checks passed
@JulienDoerner JulienDoerner deleted the cleanup branch February 13, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasmerten lukasmerten lukasmerten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JulienDoerner @lukasmerten