Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated doc for new Python interface via cmake #471

Merged
merged 5 commits into from
Feb 28, 2024
Merged

Conversation

rafaelab
Copy link
Member

Minor changes to the documentation to reflect the recent updates.

@@ -201,41 +202,13 @@ For Fedora/CentOS/RHEL the required packages to build CRPropa:
```
In case of CentOS/RHEL 7, the SWIG version is too old and has to be built from source.


### Mac OS X
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember that is was quite tricky to install crpropa on some Mac configuration, so I would suggest to keep the longer explanation for a little longer.

But maybe @reichherzerp, @sophieaerdker, or @LeanderSchlegel can comment on that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember that is was quite tricky to install crpropa on some Mac configuration, so I would suggest to keep the longer explanation for a little longer.

I tested it on my machine, @lukasmerten, and apparently things work out of the box now. I decided to remove it to avoid confusion. Let's see if the same is true for the others. But sure, maybe we can keep it as legacy information.
Btw, our OSX tests are passing without any of these flags.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I adjusted the previous version now, @lukasmerten .
I think the reason for that complicated installation had something to do with AppleClang/LLVM and OpenMP, that is why all the flags were required. I think the newer versions of the compilers handle OpenMP much better.

@rafaelab rafaelab added the documentation Issues with the documentation or wepage label Feb 23, 2024
@JulienDoerner
Copy link
Member

Hey @rafaelab,
this PR looks good for me. I would have only one minor question. We state "testet for > Python 3.0 and > SWIG 4.0.2", but SWIG itself requires at least Python 3.2. So my question is, which version of Python did we realy tested? The oldest version I ever used was 3.7.

@rafaelab
Copy link
Member Author

Hey @rafaelab, this PR looks good for me. I would have only one minor question. We state "testet for > Python 3.0 and > SWIG 4.0.2", but SWIG itself requires at least Python 3.2. So my question is, which version of Python did we realy tested? The oldest version I ever used was 3.7.

Good point, @JulienDoerner. I said 3.0 just because we don't support Python 2 anymore.
I didn't actually test versions prior to 3.7.
What is your suggestion? Should we say 3.2, or 3.7?

@lukasmerten
Copy link
Member

@rafaelab: Just put whatever is the oldest python version that is used in one of the actions. I guess that is python 3.8 in the ubuntu-20 runner.

@rafaelab rafaelab merged commit 02d5e4c into CRPropa:master Feb 28, 2024
4 checks passed
@rafaelab rafaelab deleted the doc branch February 28, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issues with the documentation or wepage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants