-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated doc for new Python interface via cmake #471
Conversation
@@ -201,41 +202,13 @@ For Fedora/CentOS/RHEL the required packages to build CRPropa: | |||
``` | |||
In case of CentOS/RHEL 7, the SWIG version is too old and has to be built from source. | |||
|
|||
|
|||
### Mac OS X |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember that is was quite tricky to install crpropa on some Mac configuration, so I would suggest to keep the longer explanation for a little longer.
But maybe @reichherzerp, @sophieaerdker, or @LeanderSchlegel can comment on that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember that is was quite tricky to install crpropa on some Mac configuration, so I would suggest to keep the longer explanation for a little longer.
I tested it on my machine, @lukasmerten, and apparently things work out of the box now. I decided to remove it to avoid confusion. Let's see if the same is true for the others. But sure, maybe we can keep it as legacy information.
Btw, our OSX tests are passing without any of these flags.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I adjusted the previous version now, @lukasmerten .
I think the reason for that complicated installation had something to do with AppleClang/LLVM and OpenMP, that is why all the flags were required. I think the newer versions of the compilers handle OpenMP much better.
Hey @rafaelab, |
Good point, @JulienDoerner. I said 3.0 just because we don't support Python 2 anymore. |
@rafaelab: Just put whatever is the oldest python version that is used in one of the actions. I guess that is python 3.8 in the ubuntu-20 runner. |
Minor changes to the documentation to reflect the recent updates.