Source sampling #478
Merged
Source sampling #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasmerten
reviewed
Mar 15, 2024
|
Looks generally good to me. I agree that we missed that additional factor from the volume element before. |
lukasmerten
approved these changes
Mar 15, 2024
|
Thanks, @JulienDoerner. Let's for some more comments and merge otherwise next week. |
|
Looks good to me, @JulienDoerner . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sampling of the position in the SNR and pulsar distribution is done in cylindrical coordinates. The current approach misses a$r$ term for the radial componet. The differential number of sampled positions should be given by $dN = f(R, z) dV = f(R, z) \ R dR\ dZ \ d\phi$ .
Additionaly the PR reduces the amount computation by skipping the normalisation of the curves. For the MC-rejection sampling only the knowleadge of the overall maximum is needed (once calculated) and not a normalized curve.