Reworking of the ObserverTimeEvolution #511
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-> detList still available as option -> custom function option added
…d getTime function
JanNiklasB
commented
Dec 19, 2024
There was a problem hiding this comment.
In this file I changed the Run_MomentumDiffusion function in cell 12:
maxD = N_obs * deltaD -> maxD = (N_obs + 1) * deltaD
since the minimum is set to D_min = deltaD
JanNiklasB
commented
Dec 19, 2024
| @@ -261,7 +262,7 @@ TEST(ObserverFeature, TimeEvolution) { | |||
|
|
|||
| // detection two | |||
| c.setCurrentStep(0.1); | |||
| c.setTrajectoryLength(10.05); | |||
| c.setTrajectoryLength(15.05); | |||
There was a problem hiding this comment.
Here I changed the trajectory length of the candidate to a length larger then the last
detection threshold so a detection is expected.
10.05 is not enough, since 10 is not a detected length (see comment on line 239)
JanNiklasB
commented
Dec 19, 2024
| public: | ||
| // List containing all used times, is constructed in constructor or by user manually | ||
| // (leave empty if you want to rather use functions) | ||
| std::vector<double> detList; |
There was a problem hiding this comment.
detList is here defined public since it is necessary that the user has full control over it
JanNiklasB
commented
Dec 19, 2024
| std::vector<double> detList; | ||
|
|
||
| // Pointer to user defined version of getTime (should return time for corresponding index) | ||
| double (*customGetTime)(int index, double min, double max, int numb); |
There was a problem hiding this comment.
the same goes for the customGetTime pointer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear All,
in this pull request, I want to introduce a reworked
ObserverTimeEvolution.I replaced the
addTimeRangefunction which filled thedetListarray with a functionthat takes the required index as an argument and returns the time that should be observed.
For that, I also changed other parts of the
ObserverTimeEvolutionclass tocorrectly utilize that new
getTimefunction.I also kept the option of using a
detListby utilizing a new constructor.Furthermore, it is possible to use a user-defined
getTimefunction by utilizingthe
setUserDefinedGetTimefunction.Additionally, I fixed the issue mentioned in #510.
For that, it was necessary to change some tests, since those handled
the maximum observed time like
max = numb * distwhen it shouldbe handled like
max = min + numb * dist.