Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fable compatability #23

Merged
merged 20 commits into from
Aug 23, 2024
Merged

Fable compatability #23

merged 20 commits into from
Aug 23, 2024

Conversation

HLWeil
Copy link
Member

@HLWeil HLWeil commented Aug 20, 2024

This PR introduces Fable compatability into the main part of the repo, namely the DynamicObj type.

  • Project was restructured to separate Fable-compatible and -incompatible part
  • Bindings for ReflectionUtils functions were added for javascript and python.
  • Some members were renamed for better differentiability of static and dynamic properties
  • Test projects were restuctured, tests rewritten to pyxpecto style and additional tests were added
  • Build project was updated and js and py build targets was added

closes #21
closes #22

@HLWeil HLWeil requested a review from kMutagene August 20, 2024 14:57
@HLWeil HLWeil marked this pull request as ready for review August 21, 2024 12:31
@HLWeil
Copy link
Member Author

HLWeil commented Aug 21, 2024

Core features implemented and tested (See Unix tests running).

Windows failing because python runner not recognizing pyxpecto Rocket emoji.

@Freymaurer any ideas?

@Freymaurer
Copy link
Member

Core features implemented and tested (See Unix tests running).

Windows failing because python runner not recognizing pyxpecto Rocket emoji.

@Freymaurer any ideas?

Enable unicode for python, see any other pyxpecto tool.

Or maxbe try --silent for reduced output

Copy link
Member

@kMutagene kMutagene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍,
I think we can safely ignore that windows tests fail due to them not being able to display the rocket emoji 🚀

Once this is released, i will update Plotly.NET to use this version, that will act as a first "stress test" and may uncover things that are not covered by the current tests.

@HLWeil HLWeil merged commit ef44100 into main Aug 23, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] DynamiObj Equality ignores different properties Revisit transpilation to JS/Python via Fable
3 participants