This repository has been archived by the owner on May 8, 2024. It is now read-only.
feat: A6 implement #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BoYanZh
suggested changes
Feb 25, 2024
BoYanZh
suggested changes
Feb 25, 2024
src/components/Footer/index.tsx
Outdated
|
|
||
| <div className='text-center'> | ||
| <Link to="/selectMovie" className='btn btn-primary my-2'> | ||
| Go to Select Movies |
There was a problem hiding this comment.
I think you can just add this link to header
src/routes.tsx
Outdated
| @@ -6,6 +6,9 @@ import MovieCreate from 'pages/MovieCreate' | |||
| import NotFound from 'pages/NotFound' | |||
| import Register from 'pages/Register' | |||
| import RegisterConfirm from 'pages/RegisterConfirm' | |||
| import SelectMovie from 'pages/SelectMovie' | |||
| import SelectSeat from 'pages/SelectSeat' | |||
| import SelectTime from 'pages/SelectTime' | |||
BoYanZh
suggested changes
Feb 26, 2024
src/routes.tsx
Outdated
| @@ -38,6 +41,18 @@ const children: RouteObject[] = [ | |||
| } | |||
| ] | |||
| }, | |||
| { | |||
| path: '/SelectMovie', | |||
| element: <SelectMovie /> | |||
There was a problem hiding this comment.
Better rename these pages to keep consistency. Like MovieCreate. Start with a noun to make it ordered together in the editor. MovieSelect, MovieTimeSelect, MovieSeatSelect.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of A6