Skip to content
This repository has been archived by the owner on May 8, 2024. It is now read-only.

feat: page navigation by privilege, testing login errors #10

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

clovertera
Copy link
Contributor

@clovertera clovertera commented Mar 19, 2024

My implementation is that admin and user trying to access /login after they already logged in get redirected - I hope this is what was expected here.
/admin is still a rough work in progress for the moment, it will be improved

about /admin, I implemented the protectedroute component inside src/routes.tsx - it was commented out before so I'm unsure if I was supposed to change this or if there was a reason this was commented out

implemented the fix for printing the error message
can I refine the error messages in the auth controller login function or do they need to stay as they are?

@BoYanZh
Copy link
Contributor

BoYanZh commented Mar 20, 2024

i think that's good, we can even just redirect admin to manage movie page. LGTM.

@BoYanZh BoYanZh merged commit 8bf1687 into main Mar 20, 2024
2 checks passed
@BoYanZh BoYanZh deleted the login-error-checking branch March 20, 2024 06:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants