This repository has been archived by the owner on May 8, 2024. It is now read-only.
feat: registration & login error handling #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clovertera
force-pushed
the
registration-functionality
branch
from
43a7d7c to
45aae40
Compare
|
AdminCreateUser is not used to register for non-users. We need a new register endpoint. |
…registration-functionality
clovertera
changed the title
BoYanZh
force-pushed
the
registration-functionality
branch
from
a20b8e1 to
0c4f817
Compare
|
Despite this error, it runs fine. Obviously though the build fails. Any guidance is appreciated. The deliverable is vague about error handling, but I'd like to implement it successfully. |
clovertera
force-pushed
the
registration-functionality
branch
from
927080e to
3558cb3
Compare
clovertera
changed the title
BoYanZh
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
still needs added user fields, needs promotion subscription method, and functionality for authenticating new user request to register seems not very secure