Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lake update #47

Closed
wants to merge 4 commits into from
Closed

Lake update #47

wants to merge 4 commits into from

Conversation

mschnorb
Copy link

@mschnorb mschnorb commented Oct 8, 2024

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

  • Feature upgrade

Does this PR introduce a breaking change?

  • No breaking change

Other information:

…p and Reservoir.h to introduce two lake layers to lake enthalpy model.
…orrect coefficient [A], constant [B], and Jacobian matrices. Also initialized value for _mixing_depth in CReservoir::BaseConstructor.
…ng procedure from Community Land Model v5. Added advective heat transfer (i.e. initializing Q_up_new and Q_dn_new). Some code clean-up.
Copy link

github-actions bot commented Oct 8, 2024

Welcome, new contributor!

It appears that this is your first Pull Request. To give credit where it's due, we ask that you add your information to the AUTHORS.md and .zenodo.json:

  • The relevant author information has been added to AUTHORS.md and .zenodo.json

Please make sure you've read our contributing guide. We look forward to reviewing your Pull Request shortly ✨

@mschnorb mschnorb closed this Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant