Buttons: don't force padding #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can run |
|
Hmm on a fresh environment/codespace on main I don't get any additional assets. I will take a look and get back to you. I agree with this change so I can merge it in once the assets can be built. |
|
I'm only getting CSS and manifest changes 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't force padding on all
<button>elements as it breaks some Bootstrap layouts.Buttons are used in Bootstrap nav as an alternative to anchors
<a>when destination is not a link.Before/after the patch:
Buttons are also used as
.btn-closefor modals and alerts. This patch fixes an alignment issue in modal headers.Before/after the patch: