Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CBRD-25510] Removed unnecessary loop in heap_get_insert_location_with_lock() function execution #5654

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

[CBRD-25510] Removed unnecessary loop in heap_get_insert_location_with_lock() function execution #5654

wants to merge 7 commits into from

Conversation

InChiJun
Copy link

@InChiJun InChiJun commented Nov 29, 2024 •
edited
Loading

http://jira.cubrid.org/browse/CBRD-25510

Purpose

  • heap_get_insert_location_with_lock() 함수에서 slot_id를 구할 때 spage_find_free_slot() 함수를 반복해서 호출한다.
  • spage_find_free_slot() 함수 내부에서 반복문으로 slot_id를 찾기 때문에 heap_get_insert_location_with_lock() 함수에서 반복 호출할 필요가 없다.

Implementation

  • heap_get_insert_location_with_lock() 함수 내에서 slot_id를 구할 때 반복으로 호출하지 않도록 처리

Remarks

  • N/A

@InChiJun InChiJun self-assigned this Nov 29, 2024
@InChiJun InChiJun requested a review from hornetmj as a code owner November 29, 2024 09:05
@InChiJun InChiJun requested review from H2SU and YeunjunLee November 29, 2024 13:52
YeunjunLee
YeunjunLee reviewed Dec 2, 2024
View reviewed changes
src/storage/heap_file.c Show resolved Hide resolved
src/storage/heap_file.c Outdated Show resolved Hide resolved
hornetmj
hornetmj reviewed Dec 2, 2024
View reviewed changes
src/storage/heap_file.c Outdated Show resolved Hide resolved
@InChiJun InChiJun marked this pull request as draft December 2, 2024 13:02
@InChiJun InChiJun marked this pull request as ready for review December 3, 2024 04:51
@InChiJun InChiJun marked this pull request as draft December 3, 2024 15:47
@InChiJun InChiJun marked this pull request as ready for review December 4, 2024 02:53
H2SU
H2SU reviewed Dec 4, 2024
View reviewed changes
src/storage/heap_file.c
}
}
#endif
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

endif 위치가 잘못된 것 같습니다.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정하였습니다.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@H2SU H2SU H2SU left review comments

@YeunjunLee YeunjunLee YeunjunLee approved these changes

@hornetmj hornetmj hornetmj approved these changes

Assignees

@InChiJun InChiJun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@InChiJun @hornetmj @H2SU @YeunjunLee