Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix constructor missing library issue when env is not activated #417

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

lorenzncode
Copy link
Member

  • Call conda.exe run in win constructor run.bat script

* Call conda.exe run in win constructor run.bat script
@lorenzncode
Copy link
Member Author

Resolves #415.

The same could be applied for Linux/MacOS (if needed or for consistency). On Linux I didn't find conda run necessary (to launch cq-editor from run.sh without activating the conda env) because RPATH is set: Library rpath: [$ORIGIN/../lib]. I see #403 is open for MacOS.

Copy link

codecov bot commented Dec 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (181adb9) 88.60% compared to head (c2f6d24) 88.60%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #417   +/-   ##
=======================================
  Coverage   88.60%   88.60%           
=======================================
  Files          19       19           
  Lines        1553     1553           
  Branches      189      189           
=======================================
  Hits         1376     1376           
  Misses        143      143           
  Partials       34       34           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adam-urbanczyk
Copy link
Member

LGTM, thanks @lorenzncode !

@adam-urbanczyk adam-urbanczyk merged commit 4ef178a into CadQuery:master Dec 6, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants