-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin for local coordinate system selectors #35
Conversation
Co-authored-by: nobkd <[email protected]>
Co-authored-by: nobkd <[email protected]>
A plugin is a good place for something like this. CadQuery users can choose whether or not to use it, and if someone figures out a cleaner way to implement it later, they can submit a PR for your plugin. @cactorium I have approved the workflows to run. Please let me know when this is ready for final review. |
I think it should be good for final review now |
@cactorium The lint check is still failing. Please be sure you are running the same black version as this plugin repo, which follows the core CQ repo.
|
Ah, whoops, thank you EDIT: it looks like that version of black is giving different formatting suggestions than the workflow run, can you confirm that it should be version 0.1.dev631+gef9d467? |
@cactorium The lint check is green now, so I think everything is ok. Thanks for the contribution! |
This adds a new plugin that adds 3 new axes to use in selectors, the local X, Y, and Z. It's pretty intrusive on how it monkey patches than how I'd like, and basically uses globals to inject the local axis vectors into the string selector parsing logic, so please let me know if you guys think there's a better way to do it