Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop eachpoint(..., useLocalCoordinates=False) from manipulating the object's location #1100

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

greyltc
Copy link
Contributor

@greyltc greyltc commented Jun 8, 2022

fixes #1099

@greyltc
Copy link
Contributor Author

greyltc commented Jun 8, 2022

Even better would be a change that turns eachpoint() into a thin wrapper around each() with only the logic for converting the objects to points.

@jmwright
Copy link
Member

jmwright commented Jan 7, 2023

@greyltc The eachpoint test seems to be failing on this PR.

@greyltc
Copy link
Contributor Author

greyltc commented Jan 7, 2023

Sorry, maybe I'm looking in the wrong place, but I can't see the details of the failure. All I can see is

Check failure on line 1059 in Build log

@azure-pipelinesazure-pipelines
/ CadQuery.cadquery (Linux_3_10)
Build log #L1059
Bash exited with code '1'.

I clicked on "View more details on Azure Pipelines" there but that takes me to a page that says "build not found".

This PR makes a fundamental change to the way eachpoint works with useLocalCoordinates=False so I assume the test pass criteria needs to be rewritten to match that, but it would be nice to see the verbose check failure output to make sure.

@codecov
Copy link

codecov bot commented Jan 7, 2023

Codecov Report

Merging #1100 (87890b8) into master (a5fadeb) will decrease coverage by 2.27%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1100      +/-   ##
==========================================
- Coverage   96.34%   94.07%   -2.28%     
==========================================
  Files          40       26      -14     
  Lines        9533     5421    -4112     
  Branches     1259      919     -340     
==========================================
- Hits         9185     5100    -4085     
+ Misses        205      190      -15     
+ Partials      143      131      -12     
Impacted Files Coverage Δ
cadquery/cq.py 92.20% <100.00%> (-0.24%) ⬇️
cadquery/occ_impl/exporters/assembly.py 100.00% <0.00%> (ø)
tests/test_cadquery.py
tests/test_sketch.py
tests/test_utils.py
tests/test_cad_objects.py
tests/test_assembly.py
tests/test_hull.py
tests/test_cqgi.py
... and 19 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eachpoint(..., useLocalCoordinates=False) manipulates the point's location when it shouldn't
3 participants