Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firstSolid() function to find the first solid between 2 points #1657

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

moOsama76
Copy link

function to find the first solid between start and end space points, with an optimized divide and conquer approach

…pace points, with an optimized divide and conqer approach
@moOsama76
Copy link
Author

Can someone help? I don't know what the AppVeyor test is about

@adam-urbanczyk
Copy link
Member

Let's start with why the PR? With the latest extensions (i.e. .filter()) to the API, you don't need to touch the codebase. If you want to share, you could also open a PR in the contrib repo.

@moOsama76
Copy link
Author

I checked filter() and I think the difference is that I return the exact point where there is a solid I don't return a workplane

@adam-urbanczyk
Copy link
Member

Then invoke or a free function...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants