Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for type annotated parameters #1694

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

openvmp
Copy link
Contributor

@openvmp openvmp commented Oct 29, 2024

Make it possible to annotate parameters with type information.
It is very important for parameters that need to default to None.

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 73.91304% with 6 lines in your changes missing coverage. Please review.

Project coverage is 95.15%. Comparing base (dfba42f) to head (35afce9).

Files with missing lines Patch % Lines
cadquery/cqgi.py 73.91% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1694      +/-   ##
==========================================
- Coverage   95.23%   95.15%   -0.08%     
==========================================
  Files          27       27              
  Lines        6521     6543      +22     
  Branches      970      976       +6     
==========================================
+ Hits         6210     6226      +16     
- Misses        187      191       +4     
- Partials      124      126       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adam-urbanczyk
Copy link
Member

Will you fix the coverage?

@openvmp
Copy link
Contributor Author

openvmp commented Nov 7, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants