Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function to sketch arc given end point and radius #1705

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

spike77453
Copy link

This adds a function to sketch an arc given only the end point and the arc's radius.

The start point of the arc is assumed to be self._endPoint() of the sketch. A third point on the arc (the arc's midpoint) is constructed by creating a vector rectangular to the arc's cord with magnitude equal to the sagitta of the arc, added to the midpoint of the arc's cord (see https://math.stackexchange.com/a/3482681).

Edge.makeThreePointArc is used to create the arc with these three point.

@spike77453 spike77453 force-pushed the feature_add_arc_by_point_and_radius branch from 40cae35 to 68e08fa Compare November 17, 2024 15:37
Copy link

codecov bot commented Nov 17, 2024

Codecov Report

Attention: Patch coverage is 30.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 95.19%. Comparing base (a175cb8) to head (68e08fa).

Files with missing lines Patch % Lines
cadquery/sketch.py 30.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1705      +/-   ##
==========================================
- Coverage   95.29%   95.19%   -0.10%     
==========================================
  Files          27       27              
  Lines        6712     6721       +9     
  Branches     1001     1001              
==========================================
+ Hits         6396     6398       +2     
- Misses        193      200       +7     
  Partials      123      123              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant