Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top face of water/lavafalls mistakenly not rendered #171

Closed
ghost opened this issue Jul 25, 2020 · 8 comments · Fixed by #476
Closed

Top face of water/lavafalls mistakenly not rendered #171

ghost opened this issue Jul 25, 2020 · 8 comments · Fixed by #476
Labels
S-confirmed Status: Confirmed T-bug Type: Bug

Comments

@ghost
Copy link

ghost commented Jul 25, 2020

Waterfalls and lavafalls will occasionally not render the top face. It seems to happen more frequently when the face is at a steeper angle, as seen in the screenshot.

2020-07-24_19 19 08

Notice the taller falls in the middle and left showing the issue, while the smaller fall on the right does not.

@ghost ghost added the T-bug Type: Bug label Jul 25, 2020
@Erazer750
Copy link

Thats allready a known bug and will be fixed in Sodium 0.2.0.
Its the fancy translucency bug you're describing :)

@ghost
Copy link
Author

ghost commented Jul 25, 2020

Nice to know. Thanks and sorry for the duplicate issue.

@LucilleTea
Copy link
Member

To clarify: the issue pictured here is not the lack of vertex sorting that Erazer750 is talking about, which is planned to be fixed in Sodium 0.2 and tracked in #38
Instead the issue pictured is incorrect culling of the water's faces based on the angle the chunk is viewed at.
This problem has already been fixed by 5840ca2

@jellysquid3 jellysquid3 added the R-pending-merge Resolution: Pending merge label Aug 15, 2020
@jellysquid3 jellysquid3 added this to the Release 0.2 milestone Aug 15, 2020
@amnotbananaama
Copy link
Contributor

Re-opening until merged into stable

@amnotbananaama amnotbananaama added R-pending-release Resolution: Pending release S-confirmed Status: Confirmed and removed R-pending-merge Resolution: Pending merge labels Sep 8, 2020
@jellysquid3
Copy link
Member

Fixed with 772893d.

@amnotbananaama amnotbananaama removed the R-pending-release Resolution: Pending release label Nov 3, 2020
@LucilleTea
Copy link
Member

LucilleTea commented Nov 4, 2020

This issue still occurs in some situations even after commit 772893d.

Sodium_View

Seed:
-6705514674227345575

Location:
/tp @p -409 67 110 120 -26.6

Reported by BinaryBreakpoint on the Discord, I've confirmed it.

@ghost
Copy link

ghost commented Nov 4, 2020

"BinaryBreakpoint" is using windows and in minecraft they use a FOV of 30.

@amnotbananaama amnotbananaama reopened this Nov 5, 2020
@madonuko
Copy link

madonuko commented Jan 4, 2021

2021-01-04_09-51-46.mp4

I was planning to create a new issue but I found this issue. The title confuses me a lot.
It wasn't only the top, but also the side ones. From my understanding when one of the sides of the water shares the same pixels as the dirt behind, sodium decides not to render it.

mrmangohands added a commit to mrmangohands/sodium-fabric that referenced this issue Jan 10, 2021
mrmangohands added a commit to mrmangohands/sodium-fabric that referenced this issue Jan 11, 2021
mrmangohands added a commit to mrmangohands/sodium-fabric that referenced this issue Feb 12, 2021
mrmangohands added a commit to mrmangohands/sodium-fabric that referenced this issue Feb 12, 2021
jellysquid3 pushed a commit that referenced this issue Feb 14, 2021
Prevents improper culling. Fixes #171 more thoroughly.
mrmangohands added a commit to mrmangohands/sodium-fabric that referenced this issue Feb 21, 2021
spoorn referenced this issue in spoorn/sodium-forge Jun 29, 2021
Prevents improper culling. Fixes #171 more thoroughly.
IMS212 pushed a commit to IMS212/sodium-fabric that referenced this issue Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-confirmed Status: Confirmed T-bug Type: Bug
Projects
None yet
5 participants