Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually set IncomingDirections for neighbor chunks during searching #1974

Closed
wants to merge 1 commit into from
Closed

Manually set IncomingDirections for neighbor chunks during searching #1974

wants to merge 1 commit into from

Conversation

Noryea
Copy link
Contributor

@Noryea Noryea commented Aug 10, 2023

This commit should make fewer chunks be loaded (the number approximately equals to 0.4.x)

@jellysquid3
Copy link
Member

Why? This just reintroduces the bug we fixed with #1898. You are resetting the incoming directions for a chunk every time it is enqueued, but that breaks occlusion culling.

@jellysquid3
Copy link
Member

To explain: Each chunk stores visibility information which describes which outgoing faces are visible for a given set of incoming faces. When performing the search, we can encounter a situation where the same chunk is traversed into multiple times from different directions. We use VisibilityEncoding.getOutgoingDirections to create a bit-field union of the outgoing directions over the input set of incoming directions.

@Noryea
Copy link
Contributor Author

Noryea commented Aug 11, 2023

To be frank, I expected you to ignore this pull request(or close it without explaination), because it wasn't reasonable.
I did it just for a friend of mine, who uses a laptop with Intel HD Graphics 6000 and gets a lower framerate on servers after installing Sodium 0.5.0...

Thank you for explaining the details, sorry to bother you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants