Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config API and Options Screen Redesign #2837

Open
wants to merge 31 commits into
base: dev
Choose a base branch
from

Conversation

douira
Copy link
Collaborator

@douira douira commented Oct 24, 2024

Also thanks to @KingContaria for writing code on which I based the forge mod config entrypoint loader. @IMS212 wrote the initial redesign of the options page.

There's a bunch of TODOs in the code that I want to address. Feel free to help me with them and I'll merge them into this PR.

The design of the page as well as the outwards facing API are open to feedback and remain subject to change until release.

fixes #2309
fixes #2831

@douira
Copy link
Collaborator Author

douira commented Nov 3, 2024

After implementing dynamic value constraints in the slider and cycler control elements, the remaining TODOs are not necessary for the basic required features to work and it's ready for review. The requests for additions to the API were implemented.
The search bar is not yet functional, but we can simply remove that without regressing the UX and add it when it gets implemented later. @KingContaria mentioned he wanted to work on the tooltip scroller and I plan on slowly working through the other remaining non-essential TODOs, which are related to UX/UI.
One thing I can't do and should be clarified before we release, is the automatic import of vanilla options into our options screen that @IMS212 had prototyped. I don't have that code but would integrate it if provided with it.

@douira douira marked this pull request as ready for review November 3, 2024 04:16
…od metadata is retrieved, updated documentation
@douira
Copy link
Collaborator Author

douira commented Nov 26, 2024

I've been provided by IMS's code to import vanilla options but haven't worked through that yet. @KingContaria contributed scrollable tooltips and I further reworked tooltip and donation button rendering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants