-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config API and Options Screen Redesign #2837
base: dev
Are you sure you want to change the base?
Conversation
…a's forge mod entrypoint loader code
authored by @KingContaria
fix some issues when text is too long
Co-authored-by: contaria <[email protected]>
Co-authored-by: contaria <[email protected]>
Co-authored-by: contaria <[email protected]>
fix gradient behind sidebar, change layout of buttons and options panes, fix overlapping ui elements, fix scissor areas, make spacings and arrangement consistent
…t need to implement both entrypoints even if they only need the late ("main") one
refactor option applying, move flag processing into Config,
After implementing dynamic value constraints in the slider and cycler control elements, the remaining TODOs are not necessary for the basic required features to work and it's ready for review. The requests for additions to the API were implemented. |
…od metadata is retrieved, updated documentation
… class, moved donation button logic into own class, refactored layout
I've been provided by IMS's code to import vanilla options but haven't worked through that yet. @KingContaria contributed scrollable tooltips and I further reworked tooltip and donation button rendering. |
Also thanks to @KingContaria for writing code on which I based the forge mod config entrypoint loader. @IMS212 wrote the initial redesign of the options page.
There's a bunch of TODOs in the code that I want to address. Feel free to help me with them and I'll merge them into this PR.
The design of the page as well as the outwards facing API are open to feedback and remain subject to change until release.
fixes #2309
fixes #2831