Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: resolve keyring flag properly #131

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

dudong2
Copy link
Collaborator

@dudong2 dudong2 commented Aug 2, 2024

Description

ref. cosmos/cosmos-sdk#19060

how to test

  • test command cantod tx feegrant prune --from <addr> --gas-prices 10000000000000000acanto --home <home dir> --chain-id canto_7700-1 --keyring-backend test. If no error occured, it is fixed well.

Closes: #87


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • included the necessary unit and integration tests
  • reviewed "Files changed" and left comments if necessary

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@dudong2 dudong2 mentioned this pull request Aug 2, 2024
10 tasks
@dongsam dongsam force-pushed the patch/keyring-changelog branch from 4c46f6d to fca2b87 Compare August 3, 2024 02:44
@dongsam dongsam added bug Something isn't working documentation Improvements or additions to documentation labels Aug 3, 2024
@dongsam dongsam marked this pull request as ready for review August 3, 2024 02:56
Copy link
Collaborator

@dongsam dongsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review for this PR has been completed in in b-harvest#88 and b-harvest#89, and since it was a simple cli level bug fix and docs update without state logical modification, I will proceed with the merge to meet the v8 release schedule.

@dudong2 dudong2 self-assigned this Aug 3, 2024
@dongsam dongsam requested a review from tkkwon1998 August 5, 2024 03:32
@dongsam dongsam merged commit 01587ca into Canto-Network:main Aug 5, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Keyring address issue causing tx failure
2 participants