Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dep!: bump cometbft (resetting proposer priority) #134

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

zsystm
Copy link
Collaborator

@zsystm zsystm commented Aug 13, 2024

Description

problem

  • priority value is non-deterministic
    • different across nodes

solution

  • (hot fix) reset priority when network delays occur
    • use hard coded value for preventing mis configuration by validators
  • (long term) analyze root cause and patch it

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • included the necessary unit and integration tests
  • reviewed "Files changed" and left comments if necessary

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@zsystm zsystm requested review from dudong2 and dongsam August 13, 2024 13:52
Copy link
Collaborator

@dongsam dongsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@dudong2 dudong2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zsystm zsystm changed the title update: dep (fix priority) update: cometbft dep (fix priority) Aug 13, 2024
@dongsam dongsam merged commit 72eaff1 into Canto-Network:v8/develop Aug 13, 2024
8 checks passed
@dongsam dongsam changed the title update: cometbft dep (fix priority) dep!: bump cometbft (resetting proposer priority) Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants