Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump up cometbft v0.38.11 #142

Merged

Conversation

jasonsong0
Copy link

@jasonsong0 jasonsong0 commented Aug 28, 2024

Description

There was a bug that invalid txs_results returned for legacy ABCI response. (ref: link)

This patch updated cometbft version from v0.38.9 to v0.38.11 to fix the bug. (commits)
but use the cosmos-sdk version v0.50.8 as is.

fixed problem

  • eth_getLog returns block bloom event not found error for v7 blocks
  • method handler crashed error when querying a tx with v7 block

how to test

  • Querying eth_getLogs including v7 blocks
curl -X POST http://127.0.0.1:8545 -H "Content-Type: application/json" --data '{
"jsonrpc":"2.0",
"method":"eth_getLogs",
"params":[{
    "fromBlock": "0xa58679",
    "toBlock": "0xa5886c"
}],
"id":1
}'
  • Querying txid in v7 block
 curl -X POST http://127.0.0.1:8545 -H "Content-Type: application/json" --data '{
  "jsonrpc":"2.0",
  "method":"eth_getTransactionReceipt",
  "params":["0xd2a769b1531d6a6353e166cd8f992cd3eafe5d90213e754cbddef8d8db0be9a8"],
  "id":1                    
}'

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • included the necessary unit and integration tests
  • reviewed "Files changed" and left comments if necessary

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@jasonsong0 jasonsong0 marked this pull request as ready for review August 28, 2024 08:28
@dongsam dongsam requested a review from dudong2 August 28, 2024 09:21
@dudong2 dudong2 requested a review from tkkwon1998 August 28, 2024 09:56
@dudong2 dudong2 merged commit f1dbfe5 into Canto-Network:v8/develop Aug 28, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants