Update test data provider #768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PabloDinella
force-pushed
the
update-test-data-provider
branch
2 times, most recently
from
042be7a to
96d5380
Compare
PabloDinella
force-pushed
the
update-test-data-provider
branch
from
96d5380 to
7bb531b
Compare
PabloDinella
force-pushed
the
update-test-data-provider
branch
from
628dc7a to
8391fda
Compare
PabloDinella
force-pushed
the
update-test-data-provider
branch
from
8391fda to
c7376bb
Compare
|
I updated the branch according our last conversations. Created new families and volunteer, so existing authorization tests doesn't break. Also used variable names in a more intuitive way, like |
LarsKemmann
approved these changes
Oct 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I enriched TestDataProvider with some data, such as some assignments to 1 of the Friending arrangements, to ease the testing during development and have more examples.
I also added a one time recurrence monitoring policy called One Time Checkin, to the Friending policy, but there might be better real life example.
It's WIP still because I need to update the unit tests, might need some help to understand it first.