Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StringStartOrEnd Factory, LinkedQuestion Class and Component, Globe Animation #190

Open
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

xxArchitect
Copy link
Contributor

@xxArchitect xxArchitect commented Jul 20, 2022

Created a factory for StringStartOrEnd questions. The maximum string length is set to 16, and the maximum alphabet size is set to 6. This can be adjusted if needed.

Issue: #185

UPDATES:
Added LinkedQuestion component.
Issue: #192

Added LinkedQuestion class.
Issue: #199

Added GlobeAnimation component.
Issue: #145

@xxArchitect xxArchitect requested a review from MathyouMB July 20, 2022 17:12
@xxArchitect xxArchitect requested a review from a team as a code owner July 20, 2022 17:12
Copy link
Member

@MathyouMB MathyouMB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one small change that needs to be made

Copy link
Contributor Author

@xxArchitect xxArchitect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed duplicate submit method as requested.

@xxArchitect xxArchitect changed the title StringStartOrEnd Factory StringStartOrEnd Factory, LinkedQuestion Component Jul 28, 2022
@xxArchitect xxArchitect changed the title StringStartOrEnd Factory, LinkedQuestion Component StringStartOrEnd Factory, LinkedQuestion Class and Component, Globe Animation Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants