-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
StringStartOrEnd Factory, LinkedQuestion Class and Component, Globe Animation #190
Open
xxArchitect
wants to merge
22
commits into
CarletonComputerScienceSociety:master
Choose a base branch
from
xxArchitect:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
StringStartOrEnd Factory, LinkedQuestion Class and Component, Globe Animation #190
xxArchitect
wants to merge
22
commits into
CarletonComputerScienceSociety:master
from
xxArchitect:master
+479
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathyouMB
reviewed
Jul 20, 2022
MathyouMB
requested changes
Jul 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just one small change that needs to be made
xxArchitect
commented
Jul 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed duplicate submit method as requested.
Add written question initial component to forked branch
xxArchitect
changed the title
StringStartOrEnd Factory
StringStartOrEnd Factory, LinkedQuestion Component
Jul 28, 2022
Merge latest commits from original repo
xxArchitect
changed the title
StringStartOrEnd Factory, LinkedQuestion Component
StringStartOrEnd Factory, LinkedQuestion Class and Component, Globe Animation
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a factory for StringStartOrEnd questions. The maximum string length is set to 16, and the maximum alphabet size is set to 6. This can be adjusted if needed.
Issue: #185
UPDATES:
Added LinkedQuestion component.
Issue: #192
Added LinkedQuestion class.
Issue: #199
Added GlobeAnimation component.
Issue: #145