Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test cases for ZkLendLoanEntity #276

Closed
djeck1432 opened this issue Nov 1, 2024 · 16 comments · Fixed by #279
Closed

Add test cases for ZkLendLoanEntity #276

djeck1432 opened this issue Nov 1, 2024 · 16 comments · Fixed by #279
Assignees
Labels
good first issue Good for newcomers

Comments

@djeck1432
Copy link
Collaborator

djeck1432 commented Nov 1, 2024

  1. Read our Contributor Guidelines and README.
  2. add new folder data_handlers and then inside data_handlers add loan_states. here
  3. Create new test file test_zklend_loan_entity inside loan_states folder
  4. Use this already created mock classes for it here
  5. Add positive and negative test cases for this class ZkLendLoanEntity
@djeck1432 djeck1432 added good first issue Good for newcomers ODHack9 labels Nov 1, 2024
@binayak9932
Copy link
Contributor

binayak9932 commented Nov 1, 2024

I am python dev and returning contributer to this project .I contributed to this project .I think i can make the TC's on ZkLendLoanEntity pretty fast .btw I love 🍍.I will take 10 hrs to make first draft pr.

@Bosun-Josh121
Copy link
Contributor

Bosun-Josh121 commented Nov 1, 2024

I’d like to help with this.
I love 🍍

@0xdevcollins
Copy link

I'll like to work on this, I love 🍍

@TEMHITHORPHE
Copy link

Can I jump on this task?
Familiar with was is being asked.
I'll make a draft PR within the alloted time period.

@martinvibes
Copy link
Contributor

I'd be happy to do this.
please kindly assign :)

@petersdt
Copy link
Contributor

petersdt commented Nov 1, 2024

I would like to take this task, I love 🍍, ETA <= 8hrs

@Kaminar-i
Copy link
Contributor

Could I try solving this?
please kindly assign :)

@Kingsuite
Copy link
Contributor

May I take this issue on?

@djeck1432
Copy link
Collaborator Author

@TEMHITHORPHE Please prepare during next 2 hours your draft PR, otherwise you will be unassigned

@djeck1432
Copy link
Collaborator Author

@TEMHITHORPHE You were unassigned, because I can't see any draft PR

@djeck1432
Copy link
Collaborator Author

@Kaminar-i Please, start working as soon as possible, the hackathon is going to end

@binayak9932
Copy link
Contributor

@djeck1432 i can do this asap

@Kaminar-i
Copy link
Contributor

@djeck1432, thank you and don't worry, I'm on the issue

@djeck1432
Copy link
Collaborator Author

@Kaminar-i will anticipate your PR during next 4 hours

@mayasimi
Copy link
Contributor

mayasimi commented Nov 2, 2024

hi @djeck1432 if this task is avaliable am open to take it. ETA <= 8hrs

@Kaminar-i
Copy link
Contributor

hey @djeck1432 please i'm creating a PR soon

@djeck1432 djeck1432 linked a pull request Nov 2, 2024 that will close this issue
@djeck1432 djeck1432 removed a link to a pull request Nov 2, 2024
This was linked to pull requests Nov 2, 2024
@djeck1432 djeck1432 removed a link to a pull request Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants