create test_zklend_loan_entity.py #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djeck1432
requested changes
Nov 2, 2024
There was a problem hiding this comment.
Please, fix pylint issue
https://github.com/CarmineOptions/derisk-research/actions/runs/11644847355/job/32427656855?pr=280
Please, fix test cases:
https://github.com/CarmineOptions/derisk-research/actions/runs/11644847362/job/32427656865?pr=280
to run it locally, use next command:
pylint $(git ls-files 'data_handler/*.py') --disable=all --enable=C0114,C0115,C0116,C0301
|
@Kingsuite Please, fix test and pylint issues |
|
@Kingsuite Any updates? |
|
@Kingsuite Please, fix issues, hackathon is ending |
|
@Kingsuite Please, fix test cases before pushing make sure that all tests passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@djeck1432 find the pull request for #277