Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test cases for ZkLendState #277

Closed
djeck1432 opened this issue Nov 1, 2024 · 18 comments · Fixed by #280
Closed

Add test cases for ZkLendState #277

djeck1432 opened this issue Nov 1, 2024 · 18 comments · Fixed by #280
Assignees
Labels
good first issue Good for newcomers

Comments

@djeck1432
Copy link
Collaborator

  1. Read our Contributor Guidelines and README.
  2. add new folder data_handlers and then inside data_handlers add loan_states. here
  3. Create new test file test_zklend_loan_entity inside loan_states folder
  4. Use this already created mock classes for it here
  5. Create positive and negative test cases for ZklendState
@djeck1432 djeck1432 added good first issue Good for newcomers ODHack9 labels Nov 1, 2024
@binayak9932
Copy link
Contributor

binayak9932 commented Nov 1, 2024

I am python dev and returning contributer to this project .I contributed to this project .I think i can make the TC's on ZkLendState pretty fast .btw I love 🍍.I will take 10 hrs to make first draft pr.

@0xdevcollins
Copy link

I'll like to work on this, I love 🍍

@mexes20
Copy link
Contributor

mexes20 commented Nov 1, 2024

Can I work on this? I love 🍍

ETA: 12 hours

@martinvibes
Copy link
Contributor

Could I take a shot at this?

@godekina
Copy link
Contributor

godekina commented Nov 1, 2024

I would like to take this task, I love 🍍I can complete this task within 48 hours of being assigned to it, I am a Python developer and I have experience in DeFi.

@petersdt
Copy link
Contributor

petersdt commented Nov 1, 2024

I would like to take this task, I love 🍍 ETA <= 6hrs

@Kaminar-i
Copy link
Contributor

Could I take on this issue?
please kindly assign :)

@Kingsuite
Copy link
Contributor

Could I take over this issue?

@djeck1432
Copy link
Collaborator Author

@0xdevcollins Please, prepare draft PR during next 2 hours, otherwise you will be unassigned

@0xdevcollins
Copy link

Noted ser

@djeck1432
Copy link
Collaborator Author

@0xdevcollins I know that you're working on another project as well, but please, finish first this task. thank you

@djeck1432
Copy link
Collaborator Author

@0xdevcollins You were unassigned, because I don't see any draft PR

@djeck1432
Copy link
Collaborator Author

@Kingsuite please, start working as soon as possible, HAckathon is finishing soon, so we don't have a lot of time

@Kingsuite
Copy link
Contributor

@djeck1432 just seeing this will get to work now

@djeck1432
Copy link
Collaborator Author

@Kingsuite will anticipate your PR during next 4 hours

@Kingsuite
Copy link
Contributor

@djeck1432 i have written some testcases currently trying to make it run kind give me some more time

@djeck1432 djeck1432 linked a pull request Nov 2, 2024 that will close this issue
@djeck1432 djeck1432 removed a link to a pull request Nov 2, 2024
@djeck1432
Copy link
Collaborator Author

@Kingsuite I don't see your draft PR, I gave you more than usually 12 hours, didn't have any message to help you resolve some issue. 1 hour then will unassign you

@Kingsuite
Copy link
Contributor

@djeck1432 PR #280 is awaiting your review.

@djeck1432 djeck1432 linked a pull request Nov 3, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants