Issue #280: Disable the switching of process identity only after succ… #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…essfully authenticating to the backend server. When proxy auth is used, the flag to disable process identity switching was set after proxy auth, but before backend auth. And that, in turn, meant that after successful backend auth, the switching to root privs for making the automatic `chroot(2)` call of the proxy session process would silently fail, leading to unexpected `chroot(2)` failure due to EPERM.
Castaglia
commented
Nov 14, 2024
| @@ -299,8 +299,6 @@ int proxy_session_setup_env(pool *p, const char *user, int flags) { | |||
| strerror(xerrno)); | |||
| } | |||
|
|
|||
| session.disable_id_switching = TRUE; | |||
|
|
|||
There was a problem hiding this comment.
The setting of this session flag is moved to later in the session lifecycle, so that we can handle proxy auth appropriately, as when the following configuration is used:
ProxyRole forward
ProxyForwardMethod proxyuser,user@host
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…essfully authenticating to the backend server.
When proxy auth is used, the flag to disable process identity switching was set after proxy auth, but before backend auth. And that, in turn, meant that after successful backend auth, the switching to root privs for making the automatic
chroot(2)call of the proxy session process would silently fail, leading to unexpectedchroot(2)failure due to EPERM.