Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CATTY-446 Parse multiple scenes #1581

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

CATTY-446 Parse multiple scenes #1581

wants to merge 1 commit into from

Conversation

afibian
Copy link
Member

@afibian afibian commented Feb 1, 2021 •
edited by lucatp
Loading

Extends the XMLParser to parse multiple Scenes. Currently all scenes resist in memory but only the first one is used.

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Verify that the Jira ticket is in the status Ready for Development
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s git workflow (rebase and squash your commits)
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the #catty Slack channel and ask for a code reviewer

@m-herold m-herold self-requested a review February 1, 2021 15:47
@lucatp lucatp force-pushed the CATTY-446 branch 3 times, most recently from 9800c53 to eff1d9b Compare August 28, 2023 12:04
@lucatp
Copy link
Contributor

lucatp commented Sep 12, 2023

Jenkins, retest this please

@afibian @lucatp
CATTY-446 Parse multiple scenes
9b30d88 
Revert "CATTY-446 Parse multiple scenes"

Resolved Parsing Error

CATTY-446 Parse multiple scenes

Now it is building.

CATTY-446 Parse multiple scenes

Now moved files in right Directory. Now it should also work on the test System.

CATTY-446 Parse multiple scenes

Fixed non building testcases.

CATTY-446 Parse multiple scenes

Fixed some Testcases.

CATTY-446 Parse multiple scenes

Removed failing testcases because the functions needed were removed in a previous version.

CATTY-446 Parse multiple scenes

Also removed declarations of the removed functions.

CATTY-446

Fixed some testcases

CATTY-446 Parse multiple scenes

Fixed remaining test cases.

CATTY-446 Parse multiple scenes

Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-herold m-herold Awaiting requested review from m-herold

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
code review pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@afibian @lucatp @wallisch @GatCode