-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CATTY-369 Implement place visually feature #1728
base: develop
Are you sure you want to change the base?
Conversation
b4a2496
to
a59adb4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And rebase to develop please, then we're done IMO
src/Catty/ViewController/Stage/StagePresenterViewControllerScreenshotExtension.swift
Outdated
Show resolved
Hide resolved
Some issues:
Additionally, i would tint the status bar with light color mode (white) on the "place visually" screen |
ca8919c
to
a8b77d9
Compare
Thank you, I fixed the requested changes. Concerning the navigation bar: I deliberately made it transparent, because if someone is creating a fullscreen app and wants to visually place an object at the top of the screen it would not be possible as the top area would be obscured by the navigation bar. |
I rebased and also made some small changes:
I think we're good to go now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice PR, thanks @mstoeg!
While this feature works perfectly for objects without any transformation, the place visually feature is misleading/does not apply transformations when an object is
- Turned left/right
- Pointed in a certain direction
- Changed its look
It however works fine when changing an object's size. In Catroid it seems that the last visible appearance is being cached and reused when using the place visually feature. Could we do the same for Catty?
Finally, this feature does not work for landscape mode. In case landscape mode needs a significant amount of rework, I am more than happy to implement the place visually feature for landscape mode in a separate ticket while merging this already (after the previously mentioned bugs have been implemented).
(https://jira.catrob.at/browse/CATTY-369)
Your checklist for this pull request
Please review the contributing guidelines and wiki pages of this repository.