CATTY-587 Choose image from selected photos #1810
Open
+55
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket: (https://jira.catrob.at/browse/CATTY-587)
Bug Description: When the app has limited access to Photos (selected Photos in the settings) sometimes when choosing an image it doesn't get chosen and it is unclear for the user why nothing happened.
Root Cause: In iOS 14, the option for limited access has been added. In the old API (which we use) limited access looks the same as full access (for compatibility reason). See (https://developer.apple.com/documentation/photokit/phauthorizationstatus) for reference.
When trying to read the photo info of a limited file the access is denied. The app doesn't crash but also doesn't ready any data and hence nothing happens in the app.
Solution: Whenever nothing can be read from the image a check is made that verifies the iOS version and the authorizationStatus. If the status is limited a notification is shown if the user wants to change the settings of the app.
Usually, after each app start the app asks automatically to change the settings (but only once). This has been removed as there is now an explicit check for this.
Steps to test:
Your checklist for this pull request
Please review the contributing guidelines and wiki pages of this repository.