[ENG-5209] fixed preprints service startup in docker-compose #10528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opaduchak
changed the title
opaduchak
changed the title
cslzchen
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
Good catch, @opaduchak 👍 ! Verified locally that my preprints started successfully.
|
@opaduchak I just noticed this didn't get merged, maybe you can clean-up the PR? It seems like it should be closed, or merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Preprints service won't start as entrypoint is using bower which is missing from container runtime
Changes
Removed line in entrypoint which invoked bower
QA Notes
Documentation
Side Effects
Ticket
https://openscience.atlassian.net/jira/software/c/projects/ENG/boards/145?selectedIssue=ENG-5209