Replace forward slash with semicolon as delimiter for hierarchical separation #82
Conversation
TimDaub
force-pushed
the
fix/change-terminal-symbol
branch
from
07e31c2 to
2b04e06
Compare
TimDaub
changed the title
|
Hey @TimDaub - we're going through the backlog here, is this still active / relevant for review? |
|
i don‘t know I‘ve seen ppl use the chain:// scheme but the problems in #81 haven‘t changed or have they? |
|
Hey @TimDaub, could you join our Discord for CASA? I would love to discuss more in detail about this PR |
| @@ -31,7 +31,7 @@ The Asset Type is a string designed to uniquely identify the types of assets in | |||
| The `asset_type` is a case-sensitive string in the form | |||
|
|
|||
| ``` | |||
| asset_type: chain_id + "/" + asset_namespace + ":" + asset_reference | |||
| asset_type: chain_id + ";" + asset_namespace + ":" + asset_reference | |||
There was a problem hiding this comment.
| asset_type: chain_id + ";" + asset_namespace + ":" + asset_reference | |
| asset_type: chain_id + "-" + asset_namespace + ":" + asset_reference |
Would porefer if we use - instead because semicolon might break DIDs in the future:
https://www.w3.org/TR/did-core/#did-url-syntax
There was a problem hiding this comment.
Both CAIP-2 identifiers and asset namespaces may also contain -, so with - separators CAIP-19 identifiers will be ambiguous. Example:
CAIP-2: namespace:chain-1
Asset namespace: asset-namespace
Asset reference: 123
The resulting CAIP-19 asset type would be namespace:chain-1-token-namespace:123. It is not clear how it should be parsed.
Fixes #81