Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace backoff by backon library #4984

Merged
merged 5 commits into from
Nov 27, 2024
Merged

chore: replace backoff by backon library #4984

merged 5 commits into from
Nov 27, 2024

Conversation

ruseinov
Copy link
Contributor

@ruseinov ruseinov commented Nov 13, 2024

Summary of changes

This PR can wait till there is a new release of gossipsub, then the audit ignore can be removed.

Changes introduced in this pull request:

  • Replace an unmaintained backoff library with backon.

Reference issue to close (if applicable)

Closes

Other information and links

Note that this new library does not have the elapsed time constraint, instead it has a maximum number of retries.

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@ruseinov ruseinov marked this pull request as ready for review November 27, 2024 10:28
@ruseinov ruseinov requested a review from a team as a code owner November 27, 2024 10:28
@ruseinov ruseinov requested review from hanabi1224 and elmattic and removed request for a team November 27, 2024 10:28
src/beacon/drand.rs Outdated Show resolved Hide resolved
@hanabi1224 hanabi1224 added this pull request to the merge queue Nov 27, 2024
Merged via the queue into main with commit 7ea29fa Nov 27, 2024
34 checks passed
@hanabi1224 hanabi1224 deleted the ru/fix/backoff branch November 27, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants