Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove libipld usage from bitswap module #5012

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented Nov 27, 2024

Summary of changes

(Part of #5014)
libipld crate has been superseded by ipld-core. Also, to upgrade fvmto latest(together with cid version bump), we have to deprecate libipld in which cid will no longer be upgraded. This PR removes libipld usage from bitswap module in preparation for fvm(and cid) upgrade.

Changes introduced in this pull request:

  • remove libipld usage from bitswap module

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@hanabi1224 hanabi1224 marked this pull request as ready for review November 27, 2024 15:30
@hanabi1224 hanabi1224 requested a review from a team as a code owner November 27, 2024 15:30
@hanabi1224 hanabi1224 requested review from ruseinov and sudo-shashank and removed request for a team November 27, 2024 15:30
Copy link
Contributor

@ruseinov ruseinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@hanabi1224 hanabi1224 added this pull request to the merge queue Nov 28, 2024
Merged via the queue into main with commit 82c1e2a Nov 28, 2024
34 checks passed
@hanabi1224 hanabi1224 deleted the hm/no-libipld-in-bitswap branch November 28, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants