chore(deps): upgrade fvm and cid
#5015
Conversation
hanabi1224
force-pushed
the
hm/upgrade-fvm
branch
from
5cd818b
to
c226275
Compare
hanabi1224
force-pushed
the
hm/upgrade-fvm
branch
from
c226275
to
4b63e63
Compare
| @@ -42,7 +41,8 @@ pub async fn download_ipfs_file_trustlessly( | |||
| { | |||
| let mut reader = reader(url.as_str()).await?.compat(); | |||
| let mut writer = futures::io::BufWriter::new(async_fs::File::create(&tmp).await?); | |||
| rs_car_ipfs::single_file::read_single_file_seek(&mut reader, &mut writer, Some(cid)) | |||
| let cid_v10 = crate::utils::cid::cid_11_to_10(cid); | |||
| rs_car_ipfs::single_file::read_single_file_seek(&mut reader, &mut writer, Some(&cid_v10)) | |||
There was a problem hiding this comment.
cid_0_10 is needed until dapplion/rs-car#13 is merged and released.
hanabi1224
force-pushed
the
hm/upgrade-fvm
branch
from
04adf55
to
b22289e
Compare
hanabi1224
requested review from
lemmih and
elmattic
and removed request for
a team
src/utils/multihash.rs
Outdated
|
|
||
| #[derive(Clone, Copy, Debug, Eq, MultihashDigest, PartialEq)] | ||
| #[mh(alloc_size = 64)] | ||
| pub enum MultihashCodeLegacy { |
There was a problem hiding this comment.
Wow, that's quite a change on their part.
There was a problem hiding this comment.
Yeah, Identity hasher has been deprecated
https://github.com/multiformats/rust-multihash/blob/master/CHANGELOG.md#-breaking-changes
There was a problem hiding this comment.
Do we then need all of this code, or should we instead introduce a helper method to wrap this: https://github.com/multiformats/rust-multihash/blob/master/examples/identity.rs
There was a problem hiding this comment.
We do need the code. e.g. in CarBlock::validate, the code could be 0(identity) or others
pub fn validate(&self) -> anyhow::Result<()> {
let actual = {
let code = MultihashCode::try_from(self.cid.hash().code())?;
Cid::new_v1(self.cid.codec(), code.digest(&self.data))
};
anyhow::ensure!(
actual == self.cid,
"CID/Block mismatch for block {}, actual: {actual}",
self.cid
);
Ok(())
}
| @@ -73,7 +73,6 @@ ignore = [ | |||
| # Unmaintained crates that fvm2 requires, and will not change for | |||
| # compatability/consensus reasons - see | |||
| # https://github.com/filecoin-project/ref-fvm/issues/1843 | |||
| "RUSTSEC-2020-0168", # mach is unmaintained | |||
| "RUSTSEC-2022-0061", # parity-wasm is deprecated | |||
| "RUSTSEC-2024-0370", # proc-macro-error is unmaintained | |||
There was a problem hiding this comment.
RUSTSEC-2024-0370 will be fixed once we deprecate [email protected]
Cargo.toml
Outdated
| @@ -94,7 +95,7 @@ humantime = "2" | |||
| indexmap = { version = "2", features = ["serde"] } | |||
| indicatif = { version = "0.17", features = ["tokio"] } | |||
| integer-encoding = "4.0" | |||
| ipld-core = { version = "0.4", features = ["serde", "arb"] } | |||
| ipld-core = { version = "0.4", features = ['arb', 'serde'] } | |||
There was a problem hiding this comment.
any reasons to use single quotes here?
There was a problem hiding this comment.
Please re-approve @elmattic
Summary of changes
(Based on #5013)
Changes introduced in this pull request:
fvmandcidReference issue to close (if applicable)
Closes #5014
Other information and links
Change checklist