Ec2/txn table #5
Conversation
| /// Keeps track of notes that are spent in which transaction | ||
| pub struct ReceievdNoteSpends(HashMap<NoteId, TxId>); | ||
|
|
||
| pub struct ReceivedNoteTable(pub Vec<ReceivedNote>); |
There was a problem hiding this comment.
We could encapsulate this if we can
| pub struct ReceivedNoteTable(pub Vec<ReceivedNote>); | |
| pub struct ReceivedNoteTable(Vec<ReceivedNote>); |
| pub struct ReceivedNote { | ||
| // Uniquely identifies this note | ||
| note_id: NoteId, | ||
| txid: TxId, |
There was a problem hiding this comment.
Remove this if it contains duplicate data. Otherwise add a doc comment explaining why we need it
| account_id: AccountId, | ||
| //sapling: (diversifier, value, rcm) orchard: (diversifier, value, rho, rseed) | ||
| note: Note, | ||
| nf: Option<Nullifier>, |
There was a problem hiding this comment.
Comment describing the conditions under which nullifier is None and when it is Some
| // created: String, | ||
| /// Combines block height and mined_height into a txn status | ||
| tx_status: TransactionStatus, | ||
| tx_index: Option<u32>, |
There was a problem hiding this comment.
Is this the index in the transactions table or how it is referenced in the blockchain? Very confused about these
| note_id: NoteId, | ||
| output: &WalletSaplingOutput<AccountId>, | ||
| ) { | ||
| // let note_id = NoteId::new(txid, ShieldedProtocol::Sapling, output.index() as u16); |
There was a problem hiding this comment.
| // let note_id = NoteId::new(txid, ShieldedProtocol::Sapling, output.index() as u16); |
| note_id: NoteId, | ||
| output: &WalletOrchardOutput<AccountId>, | ||
| ) { | ||
| // let note_id = NoteId::new(txid, ShieldedProtocol::Orchard, output.index() as u16); |
There was a problem hiding this comment.
| // let note_id = NoteId::new(txid, ShieldedProtocol::Orchard, output.index() as u16); |
| pub fn mark_sapling_note_spent(&mut self, nf: sapling::Nullifier, txid: TxId) { | ||
| // let note = ReceivedNote { | ||
| // txid, | ||
| // output_index: todo!(), | ||
| // account_id: todo!(), | ||
| // note: todo!(), | ||
| // nf: todo!(), | ||
| // is_change: todo!(), | ||
| // memo: todo!(), | ||
| // commitment_tree_position: todo!(), | ||
| // recipient_key_scope: todo!(), | ||
| // }; | ||
| // self.sapling_spends.insert(nf, (txid, true)); | ||
| todo!() | ||
| } |
There was a problem hiding this comment.
| pub fn mark_sapling_note_spent(&mut self, nf: sapling::Nullifier, txid: TxId) { | |
| // let note = ReceivedNote { | |
| // txid, | |
| // output_index: todo!(), | |
| // account_id: todo!(), | |
| // note: todo!(), | |
| // nf: todo!(), | |
| // is_change: todo!(), | |
| // memo: todo!(), | |
| // commitment_tree_position: todo!(), | |
| // recipient_key_scope: todo!(), | |
| // }; | |
| // self.sapling_spends.insert(nf, (txid, true)); | |
| todo!() | |
| } |
| // Mark transparent UTXOs as spent | ||
| #[cfg(feature = "transparent-inputs")] | ||
| for utxo_outpoint in sent_tx.utxos_spent() { | ||
| // self.mark_transparent_utxo_spent(wdb.conn.0, tx_ref, utxo_outpoint)?; |
There was a problem hiding this comment.
| // self.mark_transparent_utxo_spent(wdb.conn.0, tx_ref, utxo_outpoint)?; |
| for output in sent_tx.outputs() { | ||
| // insert sent output | ||
|
|
||
| // TODO: Do we actually have to store these notes and outputs? |
There was a problem hiding this comment.
They do need to be added here so the wallet summary will update and the wallet will appear responsive. Zcash block time is really slow so otherwise the balance won't update for minutes and trying to build new transactions in this time will respend the same outputs.
We need to ensure the scanning logic can handle seeing the same note multiple times (once from here then once when scanning)
No description provided.