-
-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: display rcConfig flag on CLI reference page #7270
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #7270 +/- ##
=========================================
Coverage 48.51% 48.51%
=========================================
Files 600 600
Lines 40138 40142 +4
Branches 2058 2058
=========================================
+ Hits 19471 19475 +4
Misses 20629 20629
Partials 38 38 |
Performance Report✔️ no performance regression detected Full benchmark results
|
wemeetagain
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Some users might be interested in providing the configuration via file instead of CLI flags, this already exists in Lodestar via
--rcConfig
flag but it's a hidden option but I feel like it would be good to document this flag on our CLI reference page, see #7234 for more context.Description
Display
--rcConfig
flag on CLI reference page.I added the flag to global options as it's available for all commands (beacon, validator, bootnode, etc.), this is for documentation purposes only, the behavior of the flag is unchanged.