Internalize-pagination #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a products request
GetCategories and getCategoriesAsTree
Add options for getProducts
Change type of customFieldId to String
… additions * 'additions' of github.com:brachetti/bigcommerce-sdk: Create response for custom field creation Change customFieldId to int Replace product with product id Add create product custom field id method Change type of customFieldId to String
Fix CustomFieldResponse
Additional metadata for categories
Additional metadata for categories
sortOrder, metaKeywords, searchKeywords and customURL
additions
|
Most important for this PR is actually this commit 63b9cd3 |
|
@ryankazokas please take note that the visibility of page size has been changed to private in this PR |
|
Sorry @brachetti for the delay, we have been super busy here. Thanks for doing this! I think the overloaded method without the pagination arguments like you have here, is the way to go. We should do this for all of our public methods where applicable. If you can clean this up and add the tests, we can merge this into our develop branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5
Internalizing of Pagination into API
Changes:
Added public methods
getProducts()andgetProducts(String... includes)intoBigCommerceSdkclass.Added private method to end-recursively resolve and return paginated resources
Possible Drawbacks:
Depends on Java8
Still needs tests
Based off #4 , since it has need of
PaginatedModel<T>class