Skip to content

Commit

Permalink
Fix broken company list fetch
Browse files Browse the repository at this point in the history
Fetching companies from a paginated list is currently broken.

The issue is described here in more detail: HubSpot#324

This commit implements the fix suggested there while we await a fix on the official gem.

The other strategy i considered here was switching to use the V1 API as we already do that for a contacts list in Charlie, as that would bypass the broken code. However according to

https://legacydocs.hubspot.com/docs/methods/lists/get_list_contacts

there is no v1 API for company based lists...
  • Loading branch information
WillRogers727 committed Jul 8, 2024
1 parent 19a6bf1 commit 73885a1
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ def self.acceptable_attributes
def self.openapi_types
{
:'paging' => :'Paging',
:'results' => :'Array<Integer>'
:'results' => :'Array<Hash<String, String>>',
}
end

Expand Down

0 comments on commit 73885a1

Please sign in to comment.