-
Notifications
You must be signed in to change notification settings - Fork 59.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 style(setting): Place custom-model's input a separated row. #5879
base: main
Are you sure you want to change the base?
Conversation
@frostime is attempting to deploy a commit to the NextChat Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe changes in this pull request focus on the Changes
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
app/components/settings.tsx (1)
1778-1778
: Consider using CSS classes instead of inline styles.While the styling achieves the desired layout, consider moving these styles to a CSS module for better maintainability and consistency with the rest of the codebase.
-style={{ width: "100%", maxWidth: "unset", textAlign: "left" }} +className={styles["custom-model-input"]}Then add to your CSS module:
.custom-model-input { width: 100%; max-width: unset; text-align: left; }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
app/components/settings.tsx
(1 hunks)
🔇 Additional comments (1)
app/components/settings.tsx (1)
1774-1774
: LGTM: Vertical layout improves input field visibility.
The addition of vertical={true}
properly separates the custom model input into its own row, improving readability and usability for longer inputs.
💻 变更类型 | Change Type
🔀 变更说明 | Description of Change
自定义模型列表在 NextChat 中是否非常重要的操作,但是在设置界面中,「自定义模型」只有非常短小的一个 input 区域,非常不便于编写长自定义本文。
本 PR 将 CustomModel 设置转为 vertical 布局,从而让 input 元素单起一行,更加方便编辑。
效果如下。
变更前:
变更后:
📝 补充信息 | Additional Information
移动端下看上去应该也没啥问题。
Summary by CodeRabbit