refactor: update login flow (#74)

* refactor: increase the margin on a few details controls Increase the margin on the top image so its further from the top of the screen, and increase the margin on the login button so it more closely matches the material design * refactor: update the syncing screen ui Move the progress bar below the body text as it makes it a bit easier to see
Chesire · Jan 25, 2020 · b75e257 · b75e257
1 parent 36a6b30
commit b75e257
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 12 deletions.
diff --git a/app/src/main/res/layout/fragment_details.xml b/app/src/main/res/layout/fragment_details.xml
@@ -18,7 +18,7 @@
             android:id="@+id/detailsHeaderImage"
             android:layout_width="wrap_content"
             android:layout_height="wrap_content"
-            android:layout_marginTop="@dimen/half_margin"
+            android:layout_marginTop="@dimen/double_margin"
             android:contentDescription="@string/login_header_image_content_description"
             android:src="@drawable/ic_blackcat"
             app:layout_constraintEnd_toEndOf="parent"
@@ -105,7 +105,7 @@
         <FrameLayout
             android:layout_width="match_parent"
             android:layout_height="wrap_content"
-            android:layout_margin="@dimen/half_margin">
+            android:layout_margin="@dimen/full_margin">
 
             <com.google.android.material.button.MaterialButton
                 android:id="@+id/detailsLoginButton"

diff --git a/app/src/main/res/layout/fragment_syncing.xml b/app/src/main/res/layout/fragment_syncing.xml
@@ -19,16 +19,6 @@
         app:layout_constraintVertical_bias="0.2"
         tools:src="@drawable/ic_account_circle" />
 
-    <ProgressBar
-        android:layout_width="0dp"
-        android:layout_height="0dp"
-        android:indeterminateOnly="true"
-        android:indeterminateTint="@color/colorPrimaryDark"
-        app:layout_constraintBottom_toBottomOf="@id/syncingProfileImage"
-        app:layout_constraintEnd_toEndOf="@id/syncingProfileImage"
-        app:layout_constraintStart_toStartOf="@id/syncingProfileImage"
-        app:layout_constraintTop_toTopOf="@id/syncingProfileImage" />
-
     <TextView
         android:id="@+id/syncingSyncText"
         style="@style/TextAppearance.MaterialComponents.Headline5"
@@ -40,4 +30,17 @@
         app:layout_constraintStart_toStartOf="parent"
         app:layout_constraintTop_toBottomOf="@id/syncingProfileImage" />
 
+    <ProgressBar
+        style="@style/Widget.AppCompat.ProgressBar.Horizontal"
+        android:layout_width="0dp"
+        android:layout_height="wrap_content"
+        android:layout_marginStart="@dimen/double_margin"
+        android:layout_marginTop="@dimen/full_margin"
+        android:layout_marginEnd="@dimen/double_margin"
+        android:indeterminateOnly="true"
+        android:indeterminateTint="@color/colorPrimaryDark"
+        app:layout_constraintEnd_toEndOf="parent"
+        app:layout_constraintStart_toStartOf="parent"
+        app:layout_constraintTop_toBottomOf="@id/syncingSyncText" />
+
 </androidx.constraintlayout.widget.ConstraintLayout>
diff --git a/core/src/main/res/values/dimens.xml b/core/src/main/res/values/dimens.xml
@@ -5,6 +5,7 @@
 
     <dimen name="half_margin">8dp</dimen>
     <dimen name="full_margin">16dp</dimen>
+    <dimen name="double_margin">32dp</dimen>
 
     <dimen name="login_text_drawable_padding">8dp</dimen>