Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHIA-754] Use tx_config in cancel_pending_trades #18169

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

Quexington
Copy link
Contributor

Addresses #18142

@Quexington Quexington marked this pull request as ready for review June 12, 2024 21:26
@Quexington Quexington requested a review from a team as a code owner June 12, 2024 21:26
@Quexington Quexington added the Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog label Jun 12, 2024
@Quexington Quexington closed this Jun 17, 2024
@Quexington Quexington reopened this Jun 17, 2024
Copy link

coveralls-official bot commented Jun 18, 2024

Pull Request Test Coverage Report for Build 9549196493

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 13 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.001%) to 90.869%

Files with Coverage Reduction New Missed Lines %
chia/server/node_discovery.py 1 80.5%
chia/full_node/full_node.py 1 85.7%
chia/wallet/wallet_node.py 2 88.79%
chia/data_layer/data_layer_wallet.py 2 91.93%
chia/daemon/server.py 7 83.31%
Totals Coverage Status
Change from base Build 9524346852: -0.001%
Covered Lines: 100028
Relevant Lines: 110015

💛 - Coveralls

@Chia-Network Chia-Network deleted a comment from coveralls-official bot Jun 18, 2024
@Quexington Quexington added the ready_to_merge Submitter and reviewers think this is ready label Jun 20, 2024
@cmmarslender cmmarslender merged commit 6ed1fb0 into main Jun 21, 2024
721 of 722 checks passed
@cmmarslender cmmarslender deleted the quex.cancel_offers_reuse_puzhash branch June 21, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog ready_to_merge Submitter and reviewers think this is ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants