Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use foreground-scripts with initial npm ci to see if it resolves strange mac dlopen problem #18171

Closed
wants to merge 1 commit into from

Conversation

emlowe
Copy link
Contributor

@emlowe emlowe commented Jun 12, 2024

It seems the strange macos DL open issue may still happen even with the version update 1e67783

This is another possible workaround based on my own testing, but I have no idea if it really fixes it as the problem isn't always present or fully understood...

@emlowe emlowe requested a review from a team as a code owner June 12, 2024 22:34
@emlowe emlowe added CI CI changes Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes Changed Required label for PR that categorizes merge commit message as "Changed" for changelog labels Jun 12, 2024
Copy link

coveralls-official bot commented Jun 12, 2024

Pull Request Test Coverage Report for Build 9490653707

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 17 unchanged lines in 9 files lost coverage.
  • Overall coverage decreased (-0.005%) to 90.861%

Files with Coverage Reduction New Missed Lines %
chia/full_node/full_node_api.py 1 81.66%
chia/rpc/rpc_server.py 1 88.7%
chia/wallet/wallet_node.py 1 89.01%
chia/server/node_discovery.py 1 79.79%
chia/daemon/client.py 1 73.94%
chia/util/files.py 2 91.53%
chia/data_layer/data_store.py 3 94.37%
chia/data_layer/data_layer.py 3 85.32%
chia/full_node/full_node.py 4 85.49%
Totals Coverage Status
Change from base Build 9486908730: -0.005%
Covered Lines: 100020
Relevant Lines: 110015

💛 - Coveralls

Copy link
Contributor

@ChiaMineJP ChiaMineJP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the 'dlOpen' issue does not persist and recently CI reports no problem.
But it's good to get internal log output for the next time the bug re-appears.

@altendky
Copy link
Contributor

https://github.com/Chia-Network/chia-blockchain/actions/runs/9489995836/job/26152517447

no changes added to commit (use "git add" and/or "git commit -a")
 a963572cad5ca5f0265a163d834e534e903bdd9c ../chia-blockchain-gui (2.1.2-rc4-162-ga963572ca)
 0d3a67c2d3461b74903a951292c95733166a5bad ../mozilla-ca (heads/main)
Chia Installer Version is: 2.4.0rc2-dev19
Installing npm utilities
npm warn cleanup Failed to remove some directories [
npm warn cleanup   [
npm warn cleanup     '/Users/chia/actions-runner/_work/chia-blockchain/chia-blockchain/build_scripts/npm_macos/node_modules',
npm warn cleanup     [Error: EINVAL: invalid argument, rmdir '/Users/chia/actions-runner/_work/chia-blockchain/chia-blockchain/build_scripts/npm_macos/node_modules/@sigstore/verify/node_modules/@sigstore/protobuf-specs/dist'] {
npm warn cleanup       errno: -22,
npm warn cleanup       code: 'EINVAL',
npm warn cleanup       syscall: 'rmdir',
npm warn cleanup       path: '/Users/chia/actions-runner/_work/chia-blockchain/chia-blockchain/build_scripts/npm_macos/node_modules/@sigstore/verify/node_modules/@sigstore/protobuf-specs/dist'
npm warn cleanup     }
npm warn cleanup   ],
npm warn cleanup   [
npm warn cleanup     '/Users/chia/actions-runner/_work/chia-blockchain/chia-blockchain/build_scripts/npm_macos/node_modules/@sigstore/verify',
npm warn cleanup     [Error: EINVAL: invalid argument, rmdir '/Users/chia/actions-runner/_work/chia-blockchain/chia-blockchain/build_scripts/npm_macos/node_modules/@sigstore/verify/node_modules/@sigstore/protobuf-specs'] {
npm warn cleanup       errno: -22,
npm warn cleanup       code: 'EINVAL',
npm warn cleanup       syscall: 'rmdir',
npm warn cleanup       path: '/Users/chia/actions-runner/_work/chia-blockchain/chia-blockchain/build_scripts/npm_macos/node_modules/@sigstore/verify/node_modules/@sigstore/protobuf-specs'
npm warn cleanup     }
npm warn cleanup   ]
npm warn cleanup ]
npm error code 1
npm error path /Users/chia/actions-runner/_work/chia-blockchain/chia-blockchain/build_scripts/npm_macos/node_modules/@lerna/create/node_modules/nx
npm error command failed
npm error command sh -c node ./bin/post-install
npm error /Users/chia/actions-runner/_work/chia-blockchain/chia-blockchain/build_scripts/npm_macos/node_modules/@lerna/create/node_modules/nx/src/native/native-bindings.js:244
npm error     throw loadError
npm error     ^
npm error
npm error Error: dlopen(/Users/chia/actions-runner/_work/chia-blockchain/chia-blockchain/build_scripts/npm_macos/.nx/cache/19.0.3-nx.darwin-arm64.node, 1): no suitable image found.  Did find:
npm error 	/Users/chia/actions-runner/_work/chia-blockchain/chia-blockchain/build_scripts/npm_macos/.nx/cache/19.0.3-nx.darwin-arm64.node: code signature invalid for '/Users/chia/actions-runner/_work/chia-blockchain/chia-blockchain/build_scripts/npm_macos/.nx/cache/19.0.3-nx.darwin-arm64.node'
npm error
npm error     at Module._extensions..node (node:internal/modules/cjs/loader:1460:18)
npm error     at Module.load (node:internal/modules/cjs/loader:1203:32)
npm error     at Module._load (node:internal/modules/cjs/loader:1019:12)
npm error     at Module._load (/Users/chia/actions-runner/_work/chia-blockchain/chia-blockchain/build_scripts/npm_macos/node_modules/@lerna/create/node_modules/nx/src/native/index.js:58:27)
npm error     at Module.require (node:internal/modules/cjs/loader:1231:19)
npm error     at require (node:internal/modules/helpers:177:18)
npm error     at Object.<anonymous> (/Users/chia/actions-runner/_work/chia-blockchain/chia-blockchain/build_scripts/npm_macos/node_modules/@lerna/create/node_modules/nx/src/native/native-bindings.js:135:29)
npm error     at Module._compile (node:internal/modules/cjs/loader:1364:14)
npm error     at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)
npm error     at Module.load (node:internal/modules/cjs/loader:1203:32) {
npm error   code: 'ERR_DLOPEN_FAILED'
npm error }
npm error
npm error Node.js v18.20.3

npm error A complete log of this run can be found in: /Users/chia/.npm/_logs/2024-06-12T21_54_27_[40](https://github.com/Chia-Network/chia-blockchain/actions/runs/9489995836/job/26152517447#step:20:41)4Z-debug-0.log

The git history for this https://github.com/Chia-Network/chia-blockchain/commits/0dc23c75215eea31e166399b9e102ea615648ca6/ does show the merge of 1e67783 in 3fee057.

@ChiaMineJP
Copy link
Contributor

@emlowe I've created a PR which removes lerna and nx as build script dependencies.
#18180

@emlowe
Copy link
Contributor Author

emlowe commented Jun 18, 2024

Closing issue as hopefully everything is resolved in 18180 which removes these lines

@emlowe emlowe closed this Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog CI CI changes Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants