Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHIA-766 Deduplicate sb mempool asserts #18175

Merged

Conversation

AmineKhaldi
Copy link
Contributor

No description provided.

@AmineKhaldi AmineKhaldi added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Cleanup Code cleanup labels Jun 13, 2024
@AmineKhaldi AmineKhaldi self-assigned this Jun 13, 2024
arvidn
arvidn previously approved these changes Jun 18, 2024
@arvidn arvidn added the ready_to_merge Submitter and reviewers think this is ready label Jun 20, 2024
@arvidn
Copy link
Contributor

arvidn commented Jun 20, 2024

@cmmarslender since the one failing test is now understood to be caused by signing secrets not being available on external repos, I think we could make an exception and land this PR anyway.

@AmineKhaldi AmineKhaldi marked this pull request as ready for review June 20, 2024 12:38
@AmineKhaldi AmineKhaldi requested a review from a team as a code owner June 20, 2024 12:38
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Jun 20, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Jun 20, 2024
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@arvidn arvidn closed this Jun 20, 2024
@arvidn arvidn reopened this Jun 20, 2024
@cmmarslender cmmarslender reopened this Jun 22, 2024
@Starttoaster
Copy link
Contributor

Closing and re-opening to update CI

Copy link

coveralls-official bot commented Jun 24, 2024

Pull Request Test Coverage Report for Build 9650328670

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 13 of 13 (100.0%) changed or added relevant lines in 1 file are covered.
  • 27 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-0.02%) to 90.872%

Files with Coverage Reduction New Missed Lines %
chia/_tests/simulation/test_simulation.py 1 96.5%
chia/timelord/timelord_launcher.py 1 69.34%
chia/daemon/server.py 1 83.22%
chia/full_node/weight_proof.py 2 90.35%
chia/server/server.py 4 81.46%
chia/wallet/wallet_node.py 5 88.43%
chia/full_node/full_node.py 6 85.85%
chia/server/node_discovery.py 7 79.26%
Totals Coverage Status
Change from base Build 9650300892: -0.02%
Covered Lines: 100208
Relevant Lines: 110210

💛 - Coveralls

@Starttoaster Starttoaster merged commit bce4b4a into Chia-Network:main Jun 24, 2024
1369 of 1383 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Cleanup Code cleanup ready_to_merge Submitter and reviewers think this is ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants