Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unclosed client session warning ignore #18214

Merged
merged 1 commit into from
Jul 11, 2024
Merged

remove unclosed client session warning ignore #18214

merged 1 commit into from
Jul 11, 2024

Conversation

altendky
Copy link
Contributor

Purpose:

Current Behavior:

New Behavior:

Testing Notes:

@altendky altendky added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes labels Jun 20, 2024
@altendky altendky closed this Jun 25, 2024
@altendky altendky reopened this Jun 25, 2024
@altendky altendky marked this pull request as ready for review June 27, 2024 18:00
@altendky altendky requested a review from a team as a code owner June 27, 2024 18:00
@altendky altendky requested a review from emlowe June 27, 2024 18:00
@altendky altendky closed this Jul 9, 2024
@altendky altendky reopened this Jul 9, 2024
@coveralls-official Coveralls Official
Copy link

Pull Request Test Coverage Report for Build 9857649894

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 15 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.02%) to 90.958%
Files with Coverage Reduction New Missed Lines %
chia/_tests/simulation/test_simulation.py 1 96.5%
chia/daemon/keychain_proxy.py 1 72.57%
chia/rpc/rpc_server.py 1 88.7%
chia/farmer/farmer.py 1 72.23%
chia/daemon/client.py 1 73.33%
chia/wallet/wallet_node.py 4 88.79%
chia/full_node/full_node.py 6 85.79%
Totals Coverage Status
Change from base Build 9850517077: 0.02%
Covered Lines: 101591
Relevant Lines: 111643
💛 - Coveralls

@Starttoaster Starttoaster merged commit f41a494 into main Jul 11, 2024
1063 of 1073 checks passed
@Starttoaster Starttoaster deleted the remove_unclosed_client_ignore branch July 11, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emlowe emlowe emlowe approved these changes

Assignees
No one assigned
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Exclude_Notes Use this label if the changes in the PR should be excluded from the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@altendky @emlowe @Starttoaster