-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CHIA-1773] Add better reuse_puzhash
checking to WalletTestFramework
#18897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quexington
added
the
Changed
Required label for PR that categorizes merge commit message as "Changed" for changelog
label
Nov 19, 2024
Quexington
changed the title
Add better
[CHIA-1773] Add better Nov 20, 2024
reuse_puzhash
checking to WalletTestFramework
reuse_puzhash
checking to WalletTestFramework
|
geoffwalmsley
approved these changes
Nov 22, 2024
markelrod
approved these changes
Nov 22, 2024
code diff ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Changed
Required label for PR that categorizes merge commit message as "Changed" for changelog
coverage-diff
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(reviewing with whitespace changes hidden will be beneficial)
I learned recently that the
WalletTestFramework
testing for the respect of thereuse_puzhash
parameter in theWalletActionScope
was subpar in that it would only check for new puzzle hashes being generated as the result of farming a block. While this is a useful check, it ignored most of where the puzzle hashes get generated which is during spend construction.This PR is still not perfect, because the only thing it adds is that no puzzle hashes are generated between action scope opening/closing. If the wrong value is fed to an action scope, it can't check for that still, but hopefully as our TX endpoints become more and more standardized, that responsibility can mostly fall to mypy. Still, this is a massive improvement that identified many bugs that the framework had previously missed.