Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHIA-1830] in deep-reorg tests, ensure the resulting coin set is correct #18925

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Nov 22, 2024

Purpose:

make sure that the CoinStore's coin_record table is correct after a deep reorg.

Current Behavior:

The test does not look at the coin table.

New Behavior:

The test validates the coin table.

@arvidn arvidn added the Tests Changes to tests label Nov 22, 2024
@github-actions github-actions bot added the merge_conflict Branch has conflicts that prevent merge to main label Nov 22, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the merge_conflict Branch has conflicts that prevent merge to main label Nov 22, 2024
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@arvidn arvidn added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Nov 22, 2024
Copy link

coveralls-official bot commented Nov 22, 2024

Pull Request Test Coverage Report for Build 11979655136

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 47 of 47 (100.0%) changed or added relevant lines in 1 file are covered.
  • 30 unchanged lines in 10 files lost coverage.
  • Overall coverage increased (+0.003%) to 91.185%

Files with Coverage Reduction New Missed Lines %
chia/plotters/plotters.py 1 90.94%
chia/data_layer/data_layer.py 1 86.09%
chia/_tests/core/util/test_file_keyring_synchronization.py 1 96.88%
chia/data_layer/data_store.py 2 95.55%
chia/server/node_discovery.py 3 80.0%
chia/rpc/rpc_server.py 3 88.2%
chia/wallet/wallet_node.py 3 87.89%
chia/full_node/weight_proof.py 4 90.48%
chia/plotters/madmax.py 6 44.58%
chia/full_node/full_node.py 6 86.0%
Totals Coverage Status
Change from base Build 11978398254: 0.003%
Covered Lines: 103464
Relevant Lines: 113269

💛 - Coveralls

@arvidn arvidn marked this pull request as ready for review November 22, 2024 22:00
@arvidn arvidn requested a review from a team as a code owner November 22, 2024 22:00
@arvidn arvidn requested a review from wjblanke November 22, 2024 22:19
@arvidn arvidn changed the title in deep-reorg tests, ensure the resulting coin set is correct [CHIA-1830] in deep-reorg tests, ensure the resulting coin set is correct Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Tests Changes to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant